-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds b2bEnabled enabledFeature on CustomerSegmentTemplateApi #1361
Conversation
@@ -4,10 +4,8 @@ import type {ExtensionTarget as AnyExtensionTarget} from '../../extension-target | |||
|
|||
/* List of enabled query language features during a progressive rollout */ | |||
type CustomerSegmentationFeature = | |||
/* Allows merchants to segment on products purchased by tags. For example: products_purchased(tag: 'Red hats') = true */ | |||
| 'productsPurchasedByTags' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
products_purchased_on_tags_enabled
no longer exists
AFAIK the aggregateFilters feature was never used, and this is fully rolled out now (@LTiger14 can you confirm?)
I'm assuming we won't need these features in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even know we had that. We can remove it
@@ -21,8 +21,7 @@ export type CustomerSegmentTemplateIcon = | |||
| 'buyButtonMajor' | |||
| 'followUpEmailMajor' | |||
| 'confettiMajor' | |||
| 'viewMajor' | |||
| 'buyButtonMajor'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buyButtonMajor is listed twice
This comment has been minimized.
This comment has been minimized.
2cfb589
to
7fc0e51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor detail about the exact flag but very good with the example :)
@@ -0,0 +1,5 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm amused by curvy-turkeys-leave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always a little excited to see what the changeset file is called 😆 🦃
category: 'reEngageCustomers', | ||
}); | ||
const shopifyPlusPlanEnabled = | ||
__enabledFeatures.includes('shopifyPlusPlan'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, the actual restriction on this template should be is b2b enabled on the shop
which is mostly equivalent to being on Plus except on some dev/partner shops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the callout @ashcharles! In the figma mockups of the template, the rule of visibility was based on whether the shop was on a plus plan or not. I can make this more specific to b2b!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context around b2b but based on what Ash mentioned, I agree this flag should be more b2b specific than just plus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the name to b2bEnabled
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small note about the name. Thanks for the cleanup as well!
7fc0e51
to
c2a1b82
Compare
c2a1b82
to
0ca94ea
Compare
Background
Resolves https://github.com/Shopify/core-issues/issues/60600 (more context in https://github.com/Shopify/core-issues/issues/58095)
We want to have a template in customer segmentation that only appears in shops on the plus plan.
Solution
enabledFeature
to our API🎩
Checklist