Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProgressIndicator component #1431

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Add ProgressIndicator component #1431

merged 1 commit into from
Oct 13, 2023

Conversation

MitchLillie
Copy link
Contributor

@MitchLillie MitchLillie commented Oct 10, 2023 •
edited
Loading

Background

⚠️ Do not merge until a new version of app-kit has been consumed in web ⚠️

Closes https://github.com/Shopify/app-ui/issues/474

Is blocked by https://github.com/Shopify/app-kit/pull/605/files

Solution

🎩

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@MitchLillie MitchLillie marked this pull request as ready for review October 13, 2023 19:11
@github-actions

This comment has been minimized.

Sign in to view
@MitchLillie MitchLillie merged commit 34f0c2a into unstable Oct 13, 2023
5 checks passed
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fionoble Fionoble Fionoble left review comments

@bratsos bratsos bratsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MitchLillie @Fionoble @bratsos