fix policy modal #1458
Merged
fix policy modal #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-drexler
commented
Oct 20, 2023
| @@ -27,4 +27,7 @@ export interface PolicyModalProps { | |||
| type: PolicyType; | |||
| } | |||
|
|
|||
| export const PolicyModal = createRemoteReactComponent('PolicyModal'); | |||
| export const PolicyModal = createRemoteReactComponent< | |||
There was a problem hiding this comment.
I have honestly no idea how/why this worked before 馃
We never combined the Component with its types. We're now passing the props so that the type is complete.
robin-drexler
commented
Oct 20, 2023
| @@ -3,7 +3,8 @@ | |||
| "compilerOptions": { | |||
| "outDir": "build/ts", | |||
| "rootDir": "src", | |||
| "jsx": "react-jsx" | |||
| "jsx": "react-jsx", | |||
| "stripInternal": true | |||
There was a problem hiding this comment.
Missed this when moving back to unstable. We had in internal already. https://github.com/Shopify/ui-extensions/pull/1399/files#diff-62ec3f3adce17523e1588b957e8483dbc86b81ab9b6062022b35c69880faa6b2R6
But not for the non-react package. I've also added it here. I don't think it makes sense to only strip internals for react.
robin-drexler
force-pushed
the
rd/fix-modal
branch
from
1f85d07
to
1fb524f
Compare
robin-drexler
requested review from
renerbaffa,
brianshen1990,
oluwatimio and
lihaokx
oluwatimio
approved these changes
Oct 20, 2023
brianshen1990
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Not stripping the internal fields caused clashes in an app.
I missed moving this over. We already had this setting in internal: https://github.com/Shopify/ui-extensions/pull/1399/files#diff-256b5258d7b08eedfba647de7d28bae26f13f08d985b93f5c1ddb456644857d2R7
I also changed how the type is constructed. I have honestly no idea how/why this worked before 馃
We never combined the Component with its types. We're now passing the props so that the type is complete.
馃帺 will be done in said app, after merge.
Checklist