Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typ osp naming #1530

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Typ osp naming #1530

merged 2 commits into from
Nov 28, 2023

Conversation

rennyG
Copy link
Contributor

@rennyG rennyG commented Nov 15, 2023

Background

Partial fix for https://github.com/Shopify/shopify-dev/issues/38918

Solution

  • Thank you page
  • Order status page

馃帺

馃寑: https://shopify-dev.checkout-web-api-docs-ugwx.ren-chaturvedi.us.spin.dev/docs/api/checkout-ui-extensions/2023-10/extension-targets-overview#supported-osp-locations (for e.g.)

Checklist

  • I have 馃帺'd these changes
  • I have updated relevant documentation

@rennyG rennyG self-assigned this Nov 15, 2023
@rennyG rennyG marked this pull request as ready for review November 17, 2023 18:34
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

Copy link
Contributor

@jamesvidler jamesvidler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@rennyG rennyG merged commit 5481b94 into unstable Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants