New shipping option list API #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesvidler
changed the title
jamesvidler
requested review from
jonathanhamel4,
oliverigor,
lemonmade and
loic-d
jamesvidler
commented
Dec 6, 2023
packages/ui-extensions-react/src/surfaces/checkout/hooks/shipping-option-target.ts
Outdated
Show resolved
Hide resolved
jamesvidler
changed the title
mleandres
approved these changes
Dec 6, 2023
loic-d
reviewed
Dec 6, 2023
loic-d
reviewed
Dec 6, 2023
loic-d
reviewed
Dec 6, 2023
|
|
||
| export interface ShippingOptionListApi { | ||
| /** | ||
| * The delivery group the extension is attached to. The target will be undefined if the group is not available. |
There was a problem hiding this comment.
We didn't mention when the group will not be available.
From change log:
The target will be
undefinedif the group is not available, for example when the buyer hasn’t entered an address on One-page checkout, or when shipping is unavailable for this address.
loic-d
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Last round of 🎩 for Shipping UI extensions LGTM. I can properly access the target in React using the useDeliveryGroupTarget() hook on extensions running unstable. Other versions return undefined.
Docs + examples LGTM and were reviewed as part of @jonathanhamel4 PR 👍
oliverigor
reviewed
Dec 6, 2023
packages/ui-extensions/docs/surfaces/checkout/screenshots/choicelist-location.png
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR brings over the latest changes relating to split cart rendering of the
shipping-option-listtargets.The
purchase.checkout.shipping-option-list.render-beforeandpurchase.checkout.shipping-option-list.render-afterextension targets now include atargetto represents the delivery group it is rendering for.This is also accessible using the new
useDeliveryGroupTarget()react hook.Relevant Docs updates:
Solution
Changes brought over from private package using these instructions in vault.
🎩
Package can be tophatted using these instructions.
purchase.checkout.shipping-option-list.render-beforeuseDeliveryGroupTargethook, you should be able to retrieve the associated delivery group.Checklist