CustomerSegmentationTemplate / Introduce dateAdded prop
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-d
commented
Mar 2, 2023
| standardMetafieldDependencies?: CustomerStandardMetafieldDependency[]; | ||
| /* Date when the template was first introduced. A "New" badge will be rendered for recently introduced templates. */ | ||
| dateAdded?: Date; |
There was a problem hiding this comment.
Thoughts on this being optional/required?
There was a problem hiding this comment.
optional makes sense to me 👍🏼
lemonmade
reviewed
Mar 2, 2023
|
@lemonmade we need more granularity actually. For example:
|
|
@loic-d could these be separate extensions instead? |
|
@lemonmade I don't think this is a scalable solution. We have almost 20 first party templates at the moment and this list will continue to grow. It will be harder to maintain and I think it will lead to duplicate boilerplate code being shipped as part of each extension's bundle 🤔 |
carolopolo
approved these changes
Mar 3, 2023
jonathanhamel4
approved these changes
Mar 6, 2023
Adds changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We currently display a "New" badge for recently introduced templates. Apps can feed us the date of when the template was added and we will display the badge if the date is within a month.
I've made the prop optional because but we could just set it in the past for all existing templates. I'm open to suggestions.
Solution
(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)
🎩
Checklist