change dateAdded to iso string #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-d
approved these changes
Mar 24, 2023
carolopolo
reviewed
Mar 24, 2023
| @@ -21,7 +21,7 @@ function App({i18n, enabledFeatures}) { | |||
| icon='productsMajor' | |||
| templateQuery={templateQuery} | |||
| templateQueryToInsert={templateQueryToInsert} | |||
| dateAdded={new Date('2023-01-15')} | |||
| dateAdded={new Date('2023-01-15').toISOString()} | |||
There was a problem hiding this comment.
since this is purely used for calculation, .getTime() makes more sense from that standpoint, but i see the consistency argument too
carolopolo
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
dateAddedproperty introduced as a Date is not correctly proxied to our Web component. It has the same class instance limitations remote-ui mentions. (Only keeping prototype)Solution
Use ISO 8601 string for dates and updated the examples.
Checklist