Flatten eslint configs, removing config/rules

[BPScott]

Description

The config definitions in lib/configs, import contents from lib/configs/rules. This extra layer of indirection adds no value - nothing is ever reused.

This PR flattens this indirection, replacing require calls in lib/configs/*.js with the contents of the files being required.

This has no affect on the rulesets used, it's just tidying.

To test

Compare the evaluated output of the lib/config/*.js files on main, and in this branch and note that they are identical.

Copy the following script into the root of the repo as test.js:

const glob = require('glob');

const fileEval = glob
  .sync('./packages/eslint-plugin/lib/config/*.js')
  .map((filename) => {
    return [filename, JSON.stringify(require(filename), validatingReplacer, 2)];
  });

const formattedResult = fileEval
  .map(
    ([filename, evaluatedContent]) =>
      `## Filename: ${filename}\n\n\`\`\`\n${evaluatedContent}\n\`\`\``,
  )
  .join('\n\n');

console.log(formattedResult);

//
// UTILS
//

function validatingReplacer(key, value) {
  if (
    ['number', 'string', 'boolean'].includes(typeof value) ||
    Array.isArray(value) ||
    isPlainObject(value) ||
    value === null
  ) {
    return value;
  }

  console.log({key, value});
  throw new Error(`Found an unknown value for key ${key}!`);
}

function isPlainObject(value) {
  if (typeof value !== 'object' || value === null) {
    return false;
  }

  const prototype = Object.getPrototypeOf(value);
  return (
    (prototype === null ||
      prototype === Object.prototype ||
      Object.getPrototypeOf(prototype) === null) &&
    !(Symbol.toStringTag in value) &&
    !(Symbol.iterator in value)
  );
}

• Run the script on the main branch, run the script and save the output to a file node test.js > main-config-content.md
• Check out this branch, run the script and save the output to a file: node test.js > branch-config-content.md
• Diff the output of those two files and note that they are identical diff -u main-config-content.md branch-config-content.md

Note that modifying some file in lib/config and doing the above again shall result in some diff output to prove that changes are noticed.

[BPScott]

React and typescript-type-checking are both augment configs, not core configs, per the README.

[vsumner]

Much better.