Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update eslint versions #358

Closed
wants to merge 3 commits into from
Closed

update eslint versions #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dd3fa2
update eslint versions
m4thieulavoie Jan 20, 2023
2a2d6db
keep support for node 12
m4thieulavoie Jan 20, 2023
a280820
rollback eslint
m4thieulavoie Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rude-goats-taste.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/eslint-plugin': patch
---

bump eslint dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major breaking change thanks to the removal of the the jest/no-jest-import rule. Please update the update type.

Please write a more complete changelog entry. Please detail what packages were bumped, and to what version, such as https://github.com/Shopify/web-configs/blob/main/packages/eslint-plugin/CHANGELOG.md#breaking-change. You should also detail any potentially breaking changes - notable the removal of the jest/no-jest-import rule.

2 changes: 0 additions & 2 deletions packages/eslint-plugin/lib/config/jest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ module.exports = {
'jest/no-test-return-statement': 'error',
// Enforce lowercase test names
'jest/prefer-lowercase-title': ['error', {ignore: ['describe']}],
// Disallow importing Jest
'jest/no-jest-import': 'error',
// Disallow alias methods
'jest/no-alias-methods': 'error',
// Disallow setup and teardown hooks
Expand Down
28 changes: 14 additions & 14 deletions packages/eslint-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,32 +25,32 @@
},
"homepage": "https://github.com/Shopify/web-configs/blob/main/packages/eslint-plugin/README.md",
"dependencies": {
"@babel/eslint-parser": "^7.16.3",
"@babel/eslint-plugin": "^7.14.5",
"@typescript-eslint/eslint-plugin": "^5.4.0",
"@typescript-eslint/parser": "^5.4.0",
"@babel/eslint-parser": "^7.19.0",
"@babel/eslint-plugin": "^7.19.0",
"@typescript-eslint/eslint-plugin": "^5.48.2",
"@typescript-eslint/parser": "^5.48.2",
"change-case": "^4.1.2",
"common-tags": "^1.8.2",
"doctrine": "^2.1.0",
"eslint-config-prettier": "^8.3.0",
"eslint-config-prettier": "^8.6.0",
"eslint-module-utils": "^2.7.1",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jest": "^25.3.0",
"eslint-plugin-import": "^2.27.0",
"eslint-plugin-jest": "^26.0.0",
"eslint-plugin-jest-formatting": "^3.1.0",
"eslint-plugin-jsx-a11y": "^6.5.0",
"eslint-plugin-jsx-a11y": "^6.7.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.1.0",
"eslint-plugin-promise": "^6.0.0",
"eslint-plugin-react": "^7.30.0",
"eslint-plugin-react-hooks": "^4.3.0",
"eslint-plugin-sort-class-members": "^1.14.0",
"eslint-plugin-prettier": "^4.2.0",
"eslint-plugin-promise": "^6.1.0",
"eslint-plugin-react": "^7.32.0",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-sort-class-members": "^1.16.0",
"jsx-ast-utils": "^3.2.1",
"pkg-dir": "^5.0.0",
"pluralize": "^8.0.0"
},
"peerDependencies": {
"eslint": "^8.3.0"
"eslint": "^8.32.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the peer dependency on eslint is a breaking change. What package causes this bump and can it be reverted so that we don't force consumers to upgrade more than required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be^8.15.0. Happy to match that requirement if you judge is better 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what file you're linking me to there, the deeplink doesn't go anywhere for me (I guess because some file doesn't want to expand as the diff is so big). Could you clarify?

Searching the typescript-eslint codebase's package.json files for mention of eslint suggests that its peerDependency range for eslint is "^6.0.0 || ^7.0.0 || ^8.0.0", which doesn't seem to support the requirement change here.

},
"devDependencies": {
"react": "^16.13.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/tests/lib/config/typescript.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('config', () => {
);

expect(esLintOutput).toStrictEqual(
expect.stringContaining('2 problems (2 errors, 0 warnings)'),
expect.stringContaining('3 problems (3 errors, 0 warnings)'),
);

// import/no-cycle error
Expand Down
Loading