Use Record instead of index signatures #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix failures
jas7457
force-pushed
the
jaddleman/use-record
branch
from
8720143
to
4fd9e99
Compare
|
/snapit |
|
🫰✨ Thanks @jas7457! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @shopify/eslint-plugin@0.0.0-snapshot-20231204192806 |
vsumner
approved these changes
Dec 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes it so that
@typescript-eslint/consistent-indexed-object-styleuses the default config for error, aka use a Record and not in index signature.I created a snapshot and tested this in my repo. Here's a video showing that the switch worked and now it complains on index signatures.