Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset GEM_HOME and GEM_PATH for chruby #138

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Nov 22, 2022

#112 had been working fine when I was using rbenv. After I switched to chruby, I started to see weird errors in the version that I use for running run_benchmarks.rb.

The difference between rbenv and chruby was that chruby sets GEM_HOME and GEM_PATH in your environment, which must be unset to make bundle install with #112 work.

@k0kubun k0kubun requested a review from a team November 22, 2022 22:45
Copy link
Contributor

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
As an aside, I wish chruby wouldn't set those env vars (not the discussion here though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants