Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM-only reports aren't working #216

Closed
noahgibbs opened this issue Aug 21, 2023 · 2 comments
Closed

ARM-only reports aren't working #216

noahgibbs opened this issue Aug 21, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@noahgibbs
Copy link
Contributor

It's entirely possible to get ARM data but no x86 data for a given timestamp -- for instance, CRuby might have an x86-specific crash, or there might be a rare crash that triggers by chance on x86 but not ARM. These things happen.

Right now, those timestamps get skipped. No ARM data shows up speed.yjit.org. That's an intentional thing, because the reporting code was all written x86-only initially, and some of it has bugs when trying to report with no x86 data present.

But it's not conceptually complicated. It just needs somebody to go through and fix the bugs with those reports.

@noahgibbs noahgibbs added the bug Something isn't working label Aug 21, 2023
@rwstauner
Copy link
Contributor

ARM only reports work locally now:
268a7f7

It sounds like we could remove the flag and let this behavior always be the case.

@rwstauner rwstauner self-assigned this May 20, 2024
@maximecb
Copy link
Contributor

It sounds like we could remove the flag and let this behavior always be the case.

If it makes things simpler, sure 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants