Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize String#bytesize #258

Closed
maximecb opened this issue Sep 29, 2021 · 2 comments · Fixed by #279
Closed

Optimize String#bytesize #258

maximecb opened this issue Sep 29, 2021 · 2 comments · Fixed by #279
Assignees
@eileencodes
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@maximecb
Copy link
Contributor

This is frequently at the top of our SFR profiles and is another low-hanging fruit because of its simplicity.
@maximecb maximecb added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 29, 2021
@maximecb maximecb changed the title Optimize String#bytesize Optimize String#bytesize Sep 29, 2021
@maximecb
Copy link
Contributor Author

maximecb commented Oct 5, 2021

@eileencodes this one should be pretty easy if you're interested :)

@eileencodes
Copy link
Member

Ok! I'll take a look. :)

eileencodes added a commit to eileencodes/yjit that referenced this issue Oct 14, 2021
@eileencodes
Add String#bytesize
cc82aa1 
Fixes: Shopify#258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
@eileencodes eileencodes mentioned this issue Oct 14, 2021
Merged
noahgibbs pushed a commit that referenced this issue Oct 18, 2021
@eileencodes @noahgibbs
Add String#bytesize
6ff8def 
Fixes: #258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
noahgibbs pushed a commit that referenced this issue Oct 18, 2021
@eileencodes @noahgibbs
Add String#bytesize
7ba5511 
Fixes: #258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
XrXr pushed a commit that referenced this issue Oct 19, 2021
@eileencodes @XrXr
Add String#bytesize
89600ff 
Fixes: #258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
noahgibbs pushed a commit to Shopify/ruby that referenced this issue Oct 20, 2021
@eileencodes @noahgibbs
Add String#bytesize
a2019b8 
Fixes: Shopify/yjit#258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
XrXr pushed a commit to Shopify/ruby that referenced this issue Oct 20, 2021
@eileencodes @XrXr
Add String#bytesize
5ab2cf8 
Fixes: Shopify/yjit#258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
XrXr pushed a commit to Shopify/ruby that referenced this issue Oct 20, 2021
@eileencodes @XrXr
Add String#bytesize
08981ab 
Fixes: Shopify/yjit#258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
XrXr pushed a commit to ruby/ruby that referenced this issue Oct 20, 2021
@eileencodes @XrXr
Add String#bytesize
4cad893 
Fixes: Shopify/yjit#258

Co-authored-by: Aaron Patterson tenderlove@ruby-lang.org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eileencodes eileencodes

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add String#bytesize eileencodes/yjit
2 participants
@maximecb @eileencodes