Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopkeeper admin gui bug #586

Closed
KodxQ8 opened this issue Jul 9, 2019 · 8 comments
Closed

Shopkeeper admin gui bug #586

KodxQ8 opened this issue Jul 9, 2019 · 8 comments
Assignees
Labels
cannot-reproduce Couldn't reproduce the issue with the information provided. outdated-plugin The issue is caused by using an outdated Shopkeepers version.

Comments

@KodxQ8
Copy link

KodxQ8 commented Jul 9, 2019

Preliminaries:

  • Shopkeepers version: Latest
  • Spigot version: PAPER-107 1.14.2

  • I have checked that my issue/question does not get answered by:
  • I have checked all open and closed issues, but none seems to fit my issue/question.

Reproduction on a fresh and up-to-date Spigot server:

I was <able / not able> to reproduce my issue on a freshly setup and up-to-date Spigot server (currently <Insert output of /version command on up-to-date Spigot server>) with the latest version of Shopkeepers (currently <Insert latest tested Shopkeepers version>), with no other plugins and with no kinds of other server or client mods.

The issue:

When i open the shopkeeper and try to press anything .. it just goes to my hand- cant delete or do anything to the shopkeeper

Include:

  • Description of the issue.
  • Step-by-step instructions on how to reproduce the issue.
  • Observed behavior.
  • Expected behavior.
  • If items with special attributes are involved: Include instructions on how to create those items.
  • Server logs (from server startup until issue). Consider enabling debug mode in the config for additional console output.
  • If modified from default: Plugin configurations.
  • .. Anything else that might be useful to reproduce and identify the issue.
@blablubbabc
Copy link
Member

  • Can you try to reproduce this on an up-to-date Spigot server? Paper has some internal differences which makes it harder for me to figure out whether this is a Paper, Spigot, or plugin issue.
  • Shopkeepers v2.7.2 only supports MC 1.14.3. There are some situations in which the combination of v2.7.2 and MC 1.14.2 will break,

When i open the shopkeeper and try to press anything .. it just goes to my hand- cant delete or do anything to the shopkeeper

I cannot reproduce this behavior on an fresh Spigot server wihtout other plugins. So the issue has to be caused by something specific to your setup.

  • Try to reproduce this without other plugins. If the issue disappears, try to pin down the conflicting plugin.
  • Make sure that you are not using any client mods.
  • Check your server log for errors.

@blablubbabc blablubbabc self-assigned this Jul 9, 2019
@blablubbabc blablubbabc added bug An unexpected defect, fault, flaw, or imperfection. cannot-reproduce Couldn't reproduce the issue with the information provided. waiting Waiting for further information. Otherwise the issue will likely be closed. labels Jul 9, 2019
@AidanWright
Copy link

I was able to reproduce on git-Spigot-d05d3c1-7ad3a1f and git-Spigot-6e94473-7ad3a1f with a bungee backend

server plugins:

  • BungeeTabListPlus
  • PermissionsEx
  • Plugman
  • mcMMO
  • MaSuiteCore
  • MaSuiteChat
  • MaSuitePortals
  • Vault
  • WorldEdit
    and of course Shopkeepers

bungee plugins:

  • BungeePexBridge
  • BungeeTabListPlus
  • HubConnector
  • MaSuiteCore
  • MaSuiteChat
  • MaSuitePortals
  • FakeProtocol
  • StaffChat

I have no client mods and I am running the default minecraft launcher

When trying to click on any of the items in the chest I get the following error in console

org.bukkit.event.EventException: null
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:320) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:529) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:514) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:2162) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.PacketPlayInWindowClick.a(SourceFile:33) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.PacketPlayInWindowClick.a(SourceFile:10) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:13) ~[spigot.jar:git-Spigot-d05d3c1-7ad$
        at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:135) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:114) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.MinecraftServer.aW(MinecraftServer.java:898) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:891) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.awaitTasks(SourceFile:123) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:875) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:808) [spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212]
Caused by: java.lang.NoSuchMethodError: org.bukkit.inventory.Inventory.getTitle()Ljava/lang/String;
        at com.nisovin.shopkeepers.ui.defaults.EditorHandler.isWindow(EditorHandler.java:667) ~[?:?]
        at com.nisovin.shopkeepers.ui.UIListener.validateSession(UIListener.java:40) ~[?:?]
        at com.nisovin.shopkeepers.ui.UIListener.onInventoryClick(UIListener.java:82) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_212]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_212]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_212]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_212]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:316) ~[spigot.jar:git-Spigot-d05d3c1-7ad3a1f]
        ... 17 more```

@AidanWright
Copy link

also tried with no plugins and same error

@blablubbabc
Copy link
Member

@AidanWright Your error indicates that you are using an older version of Shopkeepers, which does not support newer versions of Spigot. Updating Shopkeepers should resolve your issue.

@KodxQ8 Do you get the same error? Which exact version of Shopkeepers are you using?

@andrius-t
Copy link

I Have same problem I'm using 2.6.0 and 1.4.3 Paper

@andrius-t
Copy link

Nvm I found newer version 2.7.2 in builds. I used the one from bukkit plugins link, which gives you 2.6.0 maybe the link needs to be updated

@blablubbabc
Copy link
Member

I used the one from bukkit plugins link, which gives you 2.6.0 maybe the link needs to be updated

The link points to the latest 'release' version. However, since Spigot 1.14.x is itself still in development phase and not considered stable (updates are being made daily), corresponding Shopkeepers versions are marked as 'beta' as well.

@blablubbabc blablubbabc added outdated-plugin The issue is caused by using an outdated Shopkeepers version. and removed bug An unexpected defect, fault, flaw, or imperfection. waiting Waiting for further information. Otherwise the issue will likely be closed. labels Jul 22, 2019
@blablubbabc
Copy link
Member

Since no further information was provided by the topic creator, I assume the discussed issue matches this ticket and therefore close this as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cannot-reproduce Couldn't reproduce the issue with the information provided. outdated-plugin The issue is caused by using an outdated Shopkeepers version.
Projects
None yet
Development

No branches or pull requests

4 participants