Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sounding Rockets and Bluedog Design Bureau. #59

Merged
merged 19 commits into from Feb 10, 2017
Merged

Add support for Sounding Rockets and Bluedog Design Bureau. #59

merged 19 commits into from Feb 10, 2017

Conversation

NexxusDrako313
Copy link
Contributor

Simple configuration, data transfer isn't needed due to packages needing
lab analysis and the range is the same as in the standard mod.

Should be right for merging as is,

Simple configuration, data transfer isn't needed due to packages needing
lab analysis and the range is the same as in the standard mod.
Is meant to be USISoundingRockets, not JX2Antenna. Bad copy and paste.
Always good to document stuff.
@ShotgunNinja ShotgunNinja added this to the 1.1.9 milestone Jan 11, 2017
I'm pedantic with formatting and commentes. heh
Also hope no-one minds the config credits there, though feel free to
remove them if you so wish.
I had some spare time so I made sme quick configs for this mod. They're
likely horribly unbalanced, but hopefully the community will give them a
pass.
@NexxusDrako313 NexxusDrako313 changed the title Add support for Sounding Rockets by RoverDude. Add support for Sounding Rockets and Bluedog Design Bureau. Jan 11, 2017
@NexxusDrako313
Copy link
Contributor Author

I just added support for Bluedog Design Bureau as well.

@ShotgunNinja
Copy link
Owner

Thanks a lot. I'll merge this before 1.1.9 release (in a week or two).

@NexxusDrako313
Copy link
Contributor Author

Sweet. Thanks!

So my balancing was terribad, so I made it closer to stock. Also forgot
some integrated core antennae, so I've added those in.
… INTERNAL antennae

Turns out a bunch of Bluedog antennae are internal with less than 5000
range which intend to be connectable. I've removed them as the most
likely use for them is to connect while on the launchpad, and you're
likely to attach antennae anyway.

I also added some forgotten probe cores and balanced both Bluedog and
Sounding Rockets.
I was thinking, perhaps it would be best to leave the intenral antennae
on these probe cores as they do not need to be deployed, there could be
control issues if these are not used due to deployment and atmosphere
stuff.
Copy and pasting CommNet power is never a good thing because of their
weird range calculations. Adding an extra 0 should go some way to fixing
the problems introduced as it will increase distance be a factor of 10,
which is needed in most cases.
@ShotgunNinja
Copy link
Owner

ShotgunNinja commented Jan 11, 2017

I have some critiques/comments:

  • Antenna dist are better expressed in scientific notation, due to the vast differences in magnitude of the values.
  • Antenna dist values need to be choosen carefully, together with the rate of transmission. The resulting transmission rates at various distances can be seen in the part tooltip in the VAB: that could help you balance them. It may be also useful to compare the ranges with the ones from the stock antennas (as defined in Signal.cfg), instead of CommNet 'power'.
  • Personally I don't like internal antennas in pods, because there are 9 different antenna parts available in stock now. I think adding these was a very bad design decision from SQUAD. That is why I don't add internal antennas to stock pods. That being said, it is up to you to decide if these pods should have internal antennas or not.

@NexxusDrako313
Copy link
Contributor Author

Alright. I'll work on this some more then. Hopefully I can get this right.

Should be all fixed now, I'll do some final testing and we should have
liftoff soon. :)
Seeing these antennas are so small, there's not really much of a range
to speak of, so I've done some balancing so it's much closer to Kerbin's
sphre of influence. Especially consideing Bluedog is based on real life
missions.
@NexxusDrako313
Copy link
Contributor Author

Should be a lot more balanced now. See my comments in 85dc5ec.

@NexxusDrako313
Copy link
Contributor Author

I've reverted that last balance fix as it's coming up way too short for my liking.

@Maxzhao1999
Copy link
Contributor

Maxzhao1999 commented Jan 14, 2017

I've realised that you have not modifiled the Bluedog science module yet so I've made it myself, hope it is okay

@PART[bluedog_MOL_Lab]:NEEDS[FeatureScience]:FOR[Kerbalism]:AFTER[Bluedog_DB]
{
  !MODULE[ModuleScienceLab] {}
  !MODULE[ModuleScienceConverter] {}

  MODULE
  {
    name = Laboratory
    researcher = Scientist
    analysis_rate = 0.003 // 3 kbps (since it's a smaller and earlier along the tech tree)
    ec_rate = 0.9
  }
}

Edit: I've tested it in 1.2.2 and it works fine so far

@NexxusDrako313
Copy link
Contributor Author

NexxusDrako313 commented Jan 14, 2017

Oh! Whoops!

I'll add that in now.

@ShotgunNinja ShotgunNinja merged commit fcc3a69 into ShotgunNinja:master Feb 10, 2017
@NexxusDrako313 NexxusDrako313 deleted the soundingrockets branch February 10, 2017 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants