Fix to check snippet items

Shougo · Jul 16, 2023 · 7008699 · 7008699
1 parent f6a2871
commit 7008699
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/denops/@ddc-sources/nvim-lsp.ts b/denops/@ddc-sources/nvim-lsp.ts
@@ -66,7 +66,7 @@ export class Source extends BaseSource<Params> {
     const isSnippetEngineRegistered = args.sourceParams.snippetEngine !== "";
     const isValid = (lspItem: LSP.CompletionItem) =>
       isSnippetEngineRegistered ||
-      lspItem.kind !== LSP.CompletionItemKind.Snippet;
+      lspItem.insertTextFormat !== LSP.InsertTextFormat.Snippet;
     let isIncomplete = false;
 
     const clients = await denops.call(

diff --git a/denops/ddc-source-nvim-lsp/completion_item.ts b/denops/ddc-source-nvim-lsp/completion_item.ts
@@ -116,8 +116,9 @@ export class CompletionItem {
     }
 
     // Expand main part
+    // If snippetEngine is unregistered, snippet candidates are excluded at the time of gather.
     const isSnippet = lspItem.insertTextFormat === LSP.InsertTextFormat.Snippet;
-    if (!isSnippet || params.snippetEngine === "") {
+    if (!isSnippet) {
       await linePatch(denops, before, after, insertText);
     } else {
       await linePatch(denops, before, after, "");