Refactor Child.main to handle EOF #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Feb 5, 2018
| self._unpacker.feed(sys.stdin.buffer.read(1)) | ||
| return self._unpacker | ||
| while True: | ||
| feed = sys.stdin.buffer.raw.read(102400) |
There was a problem hiding this comment.
This also reads up to 100kb (I am seeing ~10kb at minimum here).
Reading this byte per byte seems to be very wasteful.
|
It is very big change. I will test it later. |
|
More testers are needed. |
Closed
I've seen child processes being left over after quitting Neovim, looping in `read()`. This appears to fix it. Maybe this is what Shougo#625 tried to address also?!
|
I haven't test yet but code looks quite simple and efficient. LGTM |
|
I will test it later. |
|
It seems works. I will merge it later. |
|
Merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen child processes being left over after quitting Neovim, looping
in
read().This appears to fix it.
Maybe this is what #625
tried to address also?!