Skip to content

Commit

Permalink
- Changed g:neobundle#types#git#default_protocol default value.
Browse files Browse the repository at this point in the history
  • Loading branch information
@Shougo
Shougo committed Jul 17, 2013
1 parent 6bba5a4 commit f27fe3f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions autoload/neobundle/types/git.vim
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"=============================================================================
" FILE: git.vim
" AUTHOR: Shougo Matsushita <Shougo.Matsu@gmail.com>
" Last Modified: 31 May 2013.
" Last Modified: 17 Jul 2013.
" License: MIT license {{{
" Permission is hereby granted, free of charge, to any person obtaining
" a copy of this software and associated documentation files (the
Expand Down Expand Up @@ -29,7 +29,7 @@ set cpo&vim

" Global options definition. "{{{
call neobundle#util#set_default(
\ 'g:neobundle#types#git#default_protocol', 'git',
\ 'g:neobundle#types#git#default_protocol', 'https',
\ 'g:neobundle_default_git_protocol')
"}}}

Expand Down
6 changes: 3 additions & 3 deletions doc/neobundle.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -414,13 +414,13 @@ g:neobundle#types#raw#calc_hash_command
g:neobundle#types#git#default_protocol
*g:neobundle#types#git#default_protocol*
The default protocol used for git (github).
Note: If you need to use a proxy server, you may want to
change the value to "https".
Note: If you need to use neobundle in proxy or firewall, you
must use it in "https".

*g:neobundle_default_git_protocol*
Note: |g:neobundle_default_git_protocol| is obsolete.

Defaults to "git".
Defaults to "https".

g:neobundle#types#hg#default_protocol
*g:neobundle#types#hg#default_protocol*
Expand Down

6 comments on commit f27fe3f

@UncleBill
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shougo , why change the protocol?
After applying this change, neobundle asks me to update all of my plugins. It's a kind of nightmare

@Shougo
Copy link
Owner Author

@Shougo Shougo commented on f27fe3f Jul 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I changed default protocol. Because, github changed default protocol "git" to "https".

https://help.github.com/articles/which-remote-url-should-i-use

In above page, git protocol description is not found.

I think git protocol is default protocol for git and it is fast.
But in proxy or firewall environment, git protocol cannot be used.
I responded the firewall problem recently.

If you don't want to change default protocol, you can set g:neobundle#types#git#default_protocol manually.
I don't change the default value.

@UncleBill
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Mange
Copy link

@Mange Mange commented on f27fe3f Feb 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pain having to enter my GitHub username and an auth token every time I want to install a new bundle. I wish the protocol could be smarter and only require auth when needed... :-(

It's not feasible for me to install a keychain helper on every server I connect to either, not to talk about actually still having to sync my username and password to each and everyone of them.

I realize that this isn't your fault @Shougo. It's GitHub's fault. I should not have to log in to clone a public open-source library. Thanks for having an option at least!

@Shougo
Copy link
Owner Author

@Shougo Shougo commented on f27fe3f Feb 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is difficult problem....

@Mange
Copy link

@Mange Mange commented on f27fe3f Feb 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the drama, people. I feel really stupid now. The problem wasn't the "https", protocol. It actually did like I asked for; it was that I had a misspelling in the bundle name. When GitHub cannot find a public repository with the given name, it asks for a password to look for private repositories.

Yeah, I'm a dummy! 💀

Please sign in to comment.