Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lingrにちらりと書いたのと関連。
vimshell#interactive#decode_signal()
の実装がif
で数値の比較の連続だったのを辞書にしたところ、(この関数だけを走らせまくる)ベンチマークで比較したところ高速化しました。O(n)
からO(log n)
的な感じになったのだと思います (Vimの辞書のlookupの速度に依存)。可読性も悪化していないです。ベンチマーク