Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide IDEHelpers #27

Merged
merged 25 commits into from Jan 16, 2024
Merged

Provide IDEHelpers #27

merged 25 commits into from Jan 16, 2024

Conversation

Shresht7
Copy link
Owner

Fixes #8

@Shresht7 Shresht7 self-assigned this Dec 26, 2023
@Shresht7 Shresht7 added the enhancement New feature or request label Dec 26, 2023
@Shresht7 Shresht7 marked this pull request as draft December 27, 2023 19:28
@Shresht7 Shresht7 linked an issue Dec 28, 2023 that may be closed by this pull request
Bug: Duplication in Lua configuration settings #29
Closed
@Shresht7
Copy link
Owner Author

Lua configuration settings are written to the workspace .vscode/settings.json or *.code-workspace file.

This does not need to happen every time the extension is activated. Maybe this should be a command instead.

Updating the user's global configuration is another option, but I'd prefer not to tamper with the user's global settings.

@Shresht7 Shresht7 added the on-hold Progress is on-hold label Dec 29, 2023
@Shresht7 Shresht7 added this to the v0.1.0 milestone Dec 29, 2023
@Shresht7
Copy link
Owner Author

Shresht7 commented Jan 2, 2024

This might be useful

https://github.com/LuaLS/lua-language-server/wiki/Libraries#bundling-in-a-plugin-extension

@Shresht7
Provide IDEHelpers
90678a7 
Fixes #8
@Shresht7
Extract configuration setup logic out into a function
f820791
@Shresht7
Create enumeration for settings
c68a6ce
@Shresht7
Refactor constants
ac3166c
@Shresht7
Extract literal strings into as const objects
66a6863
@Shresht7
Refactor constant object to mirror the strings
b8a60be
@Shresht7
Extract Lua configuration out to its own file
788fe18
@Shresht7
Fix: Duplication in Lua configuration settings (Fixes #29)
a32b978
@Shresht7
Refactor: set default scope for getConfiguration()
35f1266
@Shresht7
Extract context.extensionPath out of the class
9d20df1
@Shresht7
pass down extension context to all commands
442c4f3
@Shresht7
Create command: initializeLuaConfiguration
649aebf
@Shresht7
Fix merge problems
f5ca4a4
@Shresht7
Fix: rename command
177189f
@Shresht7
Fix: commands were not registered
bdf661b
@Shresht7
Setup initializeCommands
fcf8264
@Shresht7
Create helper function to getExtensionPath
7189137
@Shresht7
Remove dependency on context
48e9044
@Shresht7
Add configuration scope prompt and update LuaConfiguration setup
631fa0f
@Shresht7
Add Publisher information
429bac3
@Shresht7
Use full PUBLISHER.ID for the extension
f41ea3c
@Shresht7 Shresht7 removed the on-hold Progress is on-hold label Jan 16, 2024
@Shresht7 Shresht7 marked this pull request as ready for review January 16, 2024 11:23
@Shresht7
Copy link
Owner Author

The infrastructure is ready, it just needs the reference files. I'll open a separate new issue for that, as this is blocking the merge here.

@Shresht7 Shresht7 mentioned this pull request Jan 16, 2024
Open
@Shresht7 Shresht7 merged commit a323ce6 into main Jan 16, 2024
@Shresht7 Shresht7 deleted the issue8 branch January 16, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Shresht7 Shresht7

Labels
enhancement New feature or request
Projects
vscode-bg3-modding
Status: Done
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Bug: Duplication in Lua configuration settings Provide IDEHelpers
1 participant
@Shresht7