Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): added the conditions on search header #13

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Conversation

Shruti3004
Copy link
Owner

@Shruti3004 Shruti3004 commented Aug 4, 2021

Description

Added the conditions on search headers.

Changes

  • Created the variables for pageParam, pageLimt.
  • Added the conditions on pages, limit and totalPages.

Before

Screenshot from 2021-08-04 17-36-00

After

Screenshot from 2021-08-04 17-36-25
Screenshot from 2021-08-04 17-38-01

How to test

Check the /searchapi.

@GMishx
Copy link
Collaborator

GMishx commented Aug 5, 2021

@Shruti3004 can this be merged or you are planning to fix the 0 issue we discussed yesterday?

Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>
@Shruti3004
Copy link
Owner Author

@Shruti3004 can this be merged or you are planning to fix the 0 issue we discussed yesterday?

@GMishx fixed the page thing for search request in this for the other requests I'll create the pr in fossology itself.

src/www/ui/search-helper.php Outdated Show resolved Hide resolved
src/www/ui/search-helper.php Outdated Show resolved Hide resolved
src/www/ui/search-helper.php Outdated Show resolved Hide resolved
Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>
@GMishx GMishx merged commit 99bce6d into master Aug 5, 2021
@GMishx GMishx deleted the feat/search branch August 5, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants