Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pdd comments #10

Merged
merged 1 commit into from
Nov 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/graphic/lwjgl/window/BaseWindowPointer.java
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ public BaseWindowPointer(final Pos pos, final Size size) {


// @todo #1 The static initialization of GlfwBaseInit is dangerous. If a
// user uses this constructor, he won't be able to tell which GlfwInit
// implementation was used and could then use another. The glfw
// implementation should know somehow that there is already another glfw
// instance
// user uses this constructor, he won't be able to tell which GlfwInit
// implementation was used and could then use another. The glfw
// implementation should know somehow that there is already another glfw
// instance
/**
* Secondary constructor. Uses the static initialization of
* {@link GlfwBaseInit}.
Expand Down Expand Up @@ -107,7 +107,7 @@ public BaseWindowPointer(final Area area, final GlfwInit glfw) {
public final void close() throws Exception {
// @checkstyle MethodBodyCommentsCheck (2 lines)
// @todo #2 It should be checked whether it's really fine to add methods
// to an extended class
// to an extended class
this.glfw.close();
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/graphic/lwjgl/window/LwjBaseWindow.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@


// @todo #3 A window seems to have a minimum width of 120. I should be at least be
// able to retrieve that size
// able to retrieve that size
/**
* A window using lwjgl to show itself. Note that this class only represents the
* window without any threads. It's enough to start the window, but one has to
Expand Down