Possible improvements?

[grahampugh]

Hey ftiff,

We're using this app a lot: thanks! A couple of things I've come across using this app:

1. If the app you are trying to close doesn't exist, it spits out error 132. I think it should exit 0, since there is no problem if there is no running app to close :) I added a check in our run script to account for this.

2. I don't know if you would like to include this in the app itself, but you can determine the required AppBundleID for an application using PlistBuddy, so no need to manually find it out. See below.

We package the unmodified app to install to /Library/Application Support/JAMF/bin/MacAdminQuitApp.app and I have a template script in Jamf Pro to close whatever app I enter into Parameter 4:

#!/bin/bash

## =========================================================================
# MacAdminQuitApp template script
# Graham Pugh, 2016-11-29
## =========================================================================
## This script takes Casper script Parameter 4 for the Application name
## and the appBundleID

# Inputted variables
appName="$4"

# example for standalone testing
# appName="SuperDuper!.app"

# Path to MacAdminQuitApp
MacAdminQuitApp="/Library/Application Support/JAMF/bin/MacAdminQuitApp.app"

# Add .app to end when providing just a name e.g. "TeamViewer"
if [[ ! $appName == *".app"* ]]; then
	appName=$appName".app"
fi

# Add standard path if none provided
if [[ ! $appName == *"/"* ]]; then
	appToClose="/Applications/$appName"
else
	appToClose="$appName"
fi

if [[ -d "$appToClose" ]]; then
    # Extract the appBundleID from the chosen application using PlistBuddy
    appBundleID=$(/usr/libexec/PlistBuddy -c 'Print :CFBundleIdentifier' "$appToClose/Contents/Info.plist")
    # run the script
    "${MacAdminQuitApp}"/Contents/MacOS/MacAdminQuitApp -appPath "$appToClose" -appBundleID "$appBundleID"
    echo "$appToClose closed."
else
    # App doesn't exist!
    echo "$appToClose is not installed. Nothing to do."
fi

[ftiff]

Hi Graham,

Thanks for your report!

If the app you are trying to close doesn't exist, it spits out error 132. I think it should exit 0, since there is no problem if there is no running app to close :) I added a check in our run script to account for this.

I understand the issue… I was doing an exit(1) thinking this would use the exit code "1"… but this is not recommended. I see "1" on my Mac, though.
I'm not sure always exiting successfully is the way to go here…

I don't know if you would like to include this in the app itself, but you can determine the required AppBundleID for an application using PlistBuddy, so no need to manually find it out. See below.

Looks like I wasn't clear enough in the doc for this one :)
-appPath is sufficient for most apps (eg. /Application/iTunes.app).
But sometimes you need to quit background (agent) applications, that only have a Bundle ID. For example you might want to quit the helper. In my case I had to quit both the Citrix application and the Citrix agent.

Does it makes sense?

I really like your script. I will add it to the repo if that's ok?

[ftiff]

Posted http://stackoverflow.com/questions/42812244/swift-how-to-exit-a-macos-app-with-an-exit-code

[grahampugh]

Ah, yes I see. Like Google Drive etc. Interesting, I hadn't thought of that. I could add some logic to the script so that if parameter 5 is filled in, and differs from the app bundle ID, then use parameter 5 instead. Yes go ahead with the script! Cheers, Graham Von meinem iPhone gesendet

…

Am 15.03.2017 um 15:36 schrieb Francois Levaux-Tiffreau ***@***.***>: Posted http://stackoverflow.com/questions/42812244/swift-how-to-exit-a-macos-app-with-an-exit-code — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.