Merge pull request #2465 from SiCKRAGETV/start-recursion-fixes

Fix recursion depth error in _doLogin

sickbeard/helpers.py

@@ -1359,7 +1359,7 @@ def getURL(url, post_data=None, params={}, headers={}, timeout=30, session=None,
 
     session = _setUpSession(session, headers)
 
-    for param in params:
+    for param in params or {}:
         if isinstance(params[param], unicode):
             params[param] = params[param].encode('utf-8')
 

sickbeard/providers/generic.py

@@ -135,10 +135,6 @@ def getURL(self, url, post_data=None, params=None, timeout=30, json=False):
         for providers with special URL requirements (like cookies)
         """
 
-        # check for auth
-        if not self._doLogin():
-            return
-
         if self.proxy.isEnabled():
             self.headers.update({'Referer': self.proxy.getProxyURL()})
             self.proxyGlypeProxySSLwarning = self.proxy.getProxyURL() + 'includes/process.php?action=sslagree&submit=Continue anyway...'

sickbeard/providers/iptorrents.py

@@ -210,7 +210,7 @@ def findSearchResults(self, show, episodes, search_mode, manualSearch=False, dow
 
             addCacheEntry = False
             if not (showObj.air_by_date or showObj.sports):
-                if search_mode == 'sponly': 
+                if search_mode == 'sponly':
                     if len(parse_result.episode_numbers):
                         logger.log(
                             u"This is supposed to be a season pack search but the result " + title + " is not a valid season pack, skipping it",