FIX: Fix encoding error in Serial TL due to python3 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2019 13:50
DavidLP
requested changes
Jan 11, 2019
| @@ -40,9 +40,9 @@ def close(self): | |||
|
|
|||
| def write(self, data): | |||
| if self.write_termination is None: | |||
| self._port.write(bytes(data)) | |||
| self._port.write(bytes(data, 'utf-8')) | |||
There was a problem hiding this comment.
the constructor bytes apparently needs this explicit argument now with python 3. 'utf-8' should have been the default, so it was always implicitly used
There was a problem hiding this comment.
Mhh. Python 3 serial.write function wants byte arrays? Or utf-8 strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the encoding error in Serial TL that was coming up with the switch to python 3