Improve Verilator compatibility 3 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flooklab
commented
Dec 19, 2020
| @@ -36,8 +36,8 @@ parameter WIDTHB = 2; | |||
| parameter SIZEB = SIZEA/2; | |||
| parameter ADDRWIDTHB = 13; | |||
|
|
|||
| `define max(a,b) {(a) > (b) ? (a) : (b)} | |||
| `define min(a,b) {(a) < (b) ? (a) : (b)} | |||
There was a problem hiding this comment.
This somehow got interpreted by Verilator as repetition operator construct ({count{...}})
if I understand the error message correctly.
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 31.92% 31.92%
=======================================
Files 72 72
Lines 4780 4780
=======================================
Hits 1526 1526
Misses 3254 3254 Continue to review full report at Codecov.
|
themperek
reviewed
Dec 20, 2020
| @@ -79,7 +79,7 @@ always @(posedge CLK) | |||
| reg [31:0] DATA_BUF; | |||
| always @(posedge CLK) | |||
| if(RST) begin | |||
| DATA_BUF = 0; | |||
| DATA_BUF <= 0; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes for Verilator.