Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatone support #158

Merged
merged 17 commits into from Jun 7, 2021
Merged

Signatone support #158

merged 17 commits into from Jun 7, 2021

Conversation

Marrkson
Copy link
Contributor

@Marrkson Marrkson commented May 3, 2021

This PR adds support for the signatone prober in paris.

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #158 (1e34e34) into master (502a999) will decrease coverage by 21.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #158       +/-   ##
===========================================
- Coverage   39.21%   17.77%   -21.45%     
===========================================
  Files          72       73        +1     
  Lines        4786     4817       +31     
===========================================
- Hits         1877      856     -1021     
- Misses       2909     3961     +1052     
Impacted Files Coverage Δ
basil/HL/SignatoneProber.py 0.00% <0.00%> (ø)
basil/TL/Visa.py 0.00% <0.00%> (-88.47%) ⬇️
basil/HL/JtagGpio.py 0.00% <0.00%> (-100.00%) ⬇️
basil/HL/timestamp.py 0.00% <0.00%> (-100.00%) ⬇️
basil/utils/sim/BasilBusDriver.py 0.00% <0.00%> (-98.77%) ⬇️
basil/TL/Dummy.py 0.00% <0.00%> (-95.66%) ⬇️
basil/HL/JtagMaster.py 0.00% <0.00%> (-94.50%) ⬇️
basil/utils/sim/SiLibUsbBusDriver.py 0.00% <0.00%> (-94.31%) ⬇️
basil/HL/tlu.py 0.00% <0.00%> (-90.00%) ⬇️
basil/HL/scpi.py 0.00% <0.00%> (-84.22%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502a999...1e34e34. Read the comment docs.

Copy link
Collaborator

@michaeldaas michaeldaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me apart from the whitespace changes and the infinite loop issue.

basil/TL/Visa.py Outdated Show resolved Hide resolved
basil/TL/Visa.py Outdated Show resolved Hide resolved
examples/lab_devices/SignatoneProber.yaml Show resolved Hide resolved
basil/TL/Visa.py Show resolved Hide resolved
@michaeldaas
Copy link
Collaborator

wait, why are there commits from 2 years ago being pushed with this PR?

@Marrkson
Copy link
Contributor Author

Marrkson commented May 7, 2021

Good point, I think this is from the way I rebased. Has however no effect on todays status of the code.

Copy link
Collaborator

@michaeldaas michaeldaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the changes

Copy link
Collaborator

@DavidLP DavidLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@themperek themperek merged commit 91a50ba into master Jun 7, 2021
@themperek themperek deleted the signatone_support branch February 9, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants