-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI col and row ranges in the efficiency tab #118
Comments
The docstring of |
Yes! |
@DavidLP I'm reopening since I have a question regarding the range: Are we going from 0 to N-1 or 1 to N? Let's say for FE-I4 column range from 0 to 79 or 1 to 80? I just realised I made the minimum and maximum of the ranges from 0 to N which doesn't make sense I guess. |
Not sure, depends on if we want to have inclusive or exclusive limits on max value. Usually python, numpy and matplotlib have (min, max+1) everywhere, I think. So I would go with this convention. Should be mentioned in help Text of function. |
I guess then it's fine like it is now. |
ranges are only one way sliders, these cannot be used to set a range
The text was updated successfully, but these errors were encountered: