Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI col and row ranges in the efficiency tab #118

Closed
coquelin77 opened this issue Apr 25, 2018 · 5 comments
Closed

GUI col and row ranges in the efficiency tab #118

coquelin77 opened this issue Apr 25, 2018 · 5 comments

Comments

@coquelin77
Copy link

ranges are only one way sliders, these cannot be used to set a range

@leloup314 leloup314 added the bug label Apr 27, 2018
@leloup314
Copy link
Member

The docstring of col_range and row_range says iterable so only one pair of integers for all DUTs? E.g. col_range=(10, 70) or can this also be an iterable of iterables DUT-wise like col_range=[(10, 70), (10, 55), (10, 80), (20, 70)] where the index indicates the DUT index?

@DavidLP
Copy link
Collaborator

DavidLP commented Apr 28, 2018

Yes!

@leloup314
Copy link
Member

@DavidLP I'm reopening since I have a question regarding the range: Are we going from 0 to N-1 or 1 to N? Let's say for FE-I4 column range from 0 to 79 or 1 to 80? I just realised I made the minimum and maximum of the ranges from 0 to N which doesn't make sense I guess.

@leloup314 leloup314 reopened this May 1, 2018
@leloup314 leloup314 added the gui label May 1, 2018
@DavidLP
Copy link
Collaborator

DavidLP commented May 2, 2018

Not sure, depends on if we want to have inclusive or exclusive limits on max value. Usually python, numpy and matplotlib have (min, max+1) everywhere, I think. So I would go with this convention. Should be mentioned in help Text of function.

@leloup314
Copy link
Member

I guess then it's fine like it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants