Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editor doesn't enable editing newly added rows in any table #863

Merged

Conversation

ahmadswaid
Copy link
Collaborator

@schuelet
Copy link
Collaborator

schuelet commented Apr 20, 2021

I am using the model knime://knime.mountpoint/FSK-Web/newfiles/202009031723_DRMclassicalONLY.fskx

Reading this model and opening in the editor, I can't add a new product or edit the existing one. Hazard works as intended. Maybe some element is missing in this particular model?

@mfilter
Copy link
Collaborator

mfilter commented Apr 20, 2021

I think this is a feature, not a bug.
Dose response models do not have products - see the Generic Metadata Schema: https://foodrisklabs.bfr.bund.de/wp-content/uploads/2020/11/Metadata_-Master_Table_V1.04.xlsx
HTH;
MF

@ahmadswaid
Copy link
Collaborator Author

ahmadswaid commented Apr 20, 2021

@mfilter thank you, unfortunatly that feature is not impemented. maybe a ticket has to be created for that case, if one isnot exist yet.
@schuelet the issue was related to a bug in an old commits. thanks for reporting.
anyway I have fixed them all and try my best to test adding, editing existed rows or newly created rows in all modals belong to the editor.
Please have another review. and thank you in advanced.

@codecov-commenter
Copy link

Codecov Report

Merging #863 (5747e31) into development (4bc17f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #863   +/-   ##
==============================================
  Coverage          15.69%   15.69%           
  Complexity          3635     3635           
==============================================
  Files                786      786           
  Lines              85213    85213           
  Branches           12302    12302           
==============================================
  Hits               13371    13371           
  Misses             70410    70410           
  Partials            1432     1432           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc17f4...5747e31. Read the comment docs.

Copy link
Collaborator

@schuelet schuelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@ahmadswaid ahmadswaid merged commit 1de33b0 into development Apr 21, 2021
@ahmadswaid ahmadswaid deleted the editor_bug_row_are_not_editable_immediatly_after_adding branch April 21, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants