Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NetAddress to Transport #142

Merged
merged 2 commits into from Mar 1, 2024
Merged

Rename NetAddress to Transport #142

merged 2 commits into from Mar 1, 2024

Conversation

n8maninger
Copy link
Member

No description provided.

lukechampine
lukechampine approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@lukechampine lukechampine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love Transport, since previously we've used that name for "the thing that actually does the transporting," but it's better than NetAddress 🤷🏻

@lukechampine lukechampine merged commit 66b2f8f into rhpv4 Mar 1, 2024
@lukechampine lukechampine deleted the nate/remove-netaddress branch March 1, 2024 00:48
@n8maninger n8maninger mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukechampine lukechampine lukechampine approved these changes

@ChrisSchinnerl ChrisSchinnerl Awaiting requested review from ChrisSchinnerl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n8maninger @lukechampine