types: Make (Currency).String exact #146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed removing the SI units as well, and using SC exclusively (i.e. the example above would be
2.529378333356156158367 mS
), but there was less consensus on that.Since
String
is now exact,ExactString
has been removed; if you want raw Hastings values, you can useBig
orfmt.Sprintf("%d", c)
. If you want a rounded value, you can use standard approaches to round thefloat64
returned bySiacoins
.