Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Price Pinning #316

Merged
merged 20 commits into from Mar 14, 2024
Merged

Add Support for Price Pinning #316

merged 20 commits into from Mar 14, 2024

Conversation

n8maninger
Copy link
Member

  • Adds two new endpoints, [GET] /settings/pinned and [PUT] /settings/pinned
  • Adds integrated support for explorer data. If explorer data is disabled in the config, pinning is also disabled.

@n8maninger n8maninger force-pushed the nate/add-pinning branch 2 times, most recently from 3da0f5b to 2cf69bf Compare March 10, 2024 22:24
@n8maninger n8maninger marked this pull request as ready for review March 10, 2024 22:49
@n8maninger n8maninger mentioned this pull request Mar 10, 2024
Open
4 tasks
ChrisSchinnerl
ChrisSchinnerl reviewed Mar 11, 2024
View reviewed changes
persist/sqlite/settings.go Outdated Show resolved Hide resolved
host/settings/pin/pin.go Outdated Show resolved Hide resolved
host/settings/pin/pin_test.go Outdated Show resolved Hide resolved
host/settings/pin/pin_test.go Outdated Show resolved Hide resolved
ChrisSchinnerl
ChrisSchinnerl previously approved these changes Mar 12, 2024
View reviewed changes
peterjan
peterjan reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 👍

api/endpoints.go Show resolved Hide resolved
api/endpoints.go Show resolved Hide resolved
cmd/hostd/main.go Show resolved Hide resolved
api/api.go Outdated Show resolved Hide resolved
api/options.go Show resolved Hide resolved
host/settings/pin/pin.go Show resolved Hide resolved
host/settings/pin/pin_test.go Outdated Show resolved Hide resolved
host/settings/pin/pin_test.go Outdated Show resolved Hide resolved
host/settings/pin/pin_test.go Outdated Show resolved Hide resolved
persist/sqlite/init.sql Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl merged commit 29b994c into master Mar 14, 2024
8 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the nate/add-pinning branch March 14, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@peterjan peterjan Awaiting requested review from peterjan

Assignees
No one assigned
Labels
None yet
Projects
No open projects
hostd
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@n8maninger @peterjan @ChrisSchinnerl