Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask S3 credentials in slow query log #1065

Closed
artur9010 opened this issue Mar 14, 2024 · 0 comments · Fixed by #1069
Closed

Mask S3 credentials in slow query log #1065

artur9010 opened this issue Mar 14, 2024 · 0 comments · Fixed by #1069
Assignees
Labels
bug Something isn't working

Comments

@artur9010
Copy link

Current Behavior

I saw this inside bus logs after restart

2024-03-14T13:43:42Z	WARN	db	bus/bus.go:1634	SLOW SQL >= 100ms	{"elapsed": "128.065ms", "rows": 0, "sql": "INSERT INTO `settings` (`created_at`,`key`,`value`) VALUES ('2024-03-14 13:43:42.357','s3authentication','{\"v4Keypairs\":{\"redacted\":\"redacted\",\"redacted\":\"redacted\"}}') ON DUPLICATE KEY UPDATE `value`=VALUES(`value`)"}

Expected Behavior

Do not display s3 credentials in logs

ArgoCD has a nice feature that hides all secret values inside webui, maybe something like that should be implemented here?
image

Steps to Reproduce

  1. Restart bus
  2. See logs

Version

7477f87

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

Ubuntu 22.04, kubernetes

Autopilot Config

x

Bus Config

x

Contract Set Contracts

x

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants