Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinProtocolVersion to autopilot config #1141

Closed
2 tasks
ChrisSchinnerl opened this issue Mar 28, 2024 · 1 comment · Fixed by SiaFoundation/web#584 or #1174
Closed
2 tasks

Add MinProtocolVersion to autopilot config #1141

ChrisSchinnerl opened this issue Mar 28, 2024 · 1 comment · Fixed by SiaFoundation/web#584 or #1174
Assignees

Comments

@ChrisSchinnerl
Copy link
Member

ChrisSchinnerl commented Mar 28, 2024

The goal is to allow people to define a cutoff for hosts below a certain version. e.g. v1.6.0 would mean that hosts with version v1.5.9 or below would get a 0 score.

@alexfreska
Copy link
Member

For the UI it's probably best to check if the autopilot is configured first. If it isn't, we can default to 1.6.0 unless the user sets a different value. If it is, we set the value to the empty string to not enforce a limit beyond the one the backend already enforces implicitly.

The "suggested" value we display to the user should probably be 1.6.0 too. To indicate that it's in the user's best interest to not use older hosts.

Regardless of the value set by the user, the backend won't use anything older than 1.5.9 but we can't implicitly have the backend set this value since it might cause data loss in the current landscape of hosts.

ChrisSchinnerl added a commit that referenced this issue Apr 15, 2024
That allows users to define their own minimum protocol version. e.g.
users might want to only use 1.5.9+ hosts so they can enforce that even
though `renterd`s minimum is set to `1.5.9`.

If no version is set, only the global `MinProtocolVersion` is applied. 

Related to #1141
@github-actions github-actions bot mentioned this issue Apr 16, 2024
ChrisSchinnerl added a commit that referenced this issue Apr 17, 2024
### Minor Changes

- 424636ad: The configuration now includes the min protocol version
option, the value defaults to 1.6.0 when using simple configuration
mode. Closes <#1141>
Closes <SiaFoundation/web#573>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants