Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deadcode linter #1072

Merged
merged 1 commit into from Mar 18, 2024
Merged

Remove deadcode linter #1072

merged 1 commit into from Mar 18, 2024

Conversation

ChrisSchinnerl
Copy link
Member

Keep getting WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. but it seems like we already have unused so I'm removing deadcode

peterjan
peterjan approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I added unused and unparam first and then added deadcode at the very end, it did catch something the other two didn't catch but seems like unused is the most important one indeed.

@ChrisSchinnerl ChrisSchinnerl merged commit 6186a0a into dev Mar 18, 2024
9 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/remove-deadcode-lint branch March 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjan peterjan peterjan approved these changes

@n8maninger n8maninger Awaiting requested review from n8maninger

Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisSchinnerl @peterjan