Fetch hosts using the search endpoint #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
requested changes
Mar 19, 2024
peterjan
commented
Mar 19, 2024
peterjan
force-pushed
the
pj/host-filter-mode
branch
from
88739ac
to
342f116
Compare
peterjan
force-pushed
the
pj/host-filter-mode
branch
from
342f116
to
36021ab
Compare
peterjan
changed the title
peterjan
changed the title
ChrisSchinnerl
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
Hostsfrom thebusinterfaces and usesSearchHostsinstead. This allows us to fetch all hosts, which in turn allows us to correct/improve the usability checks.