Fix HostPruning NDF #272
Merged
Fix HostPruning NDF #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/fix-host-pruning-ndf
branch
from
8359eaa
to
bbe2052
Compare
ChrisSchinnerl
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took me a while to realise where the NDF came from but realised it was the worker's interactions buffer.
I rewrote the test in a way that should 100% prevent an NDF from occurring. I can be sure of that because I shut the worker down manually, that's obviously a bit sketchy but if it prevents the NDF it's well worth it imo. I've also removed the
Retry(for the check at least) and tweaked the failed interactions and downtime to push it right before the threshold, and then over it, making the integration test way more solid.