Fix range requests #279
Merged
Fix range requests #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/fix-range-requests
branch
from
430f242
to
5bf9f74
Compare
ChrisSchinnerl
commented
Apr 13, 2023
| if err != nil { | ||
| jc.Error(err, http.StatusRequestedRangeNotSatisfiable) | ||
| return | ||
| } | ||
| if length < obj.Size() { | ||
| jc.ResponseWriter.WriteHeader(http.StatusPartialContent) |
There was a problem hiding this comment.
This was the issue. Writing the header first before setting all the other fields.
ChrisSchinnerl
commented
Apr 13, 2023
| } | ||
| jc.ResponseWriter.Header().Set("Content-Length", strconv.FormatInt(length, 10)) | ||
| jc.ResponseWriter.Header().Set("Accept-Ranges", "bytes") |
There was a problem hiding this comment.
Added this for good measure.
ChrisSchinnerl
commented
Apr 13, 2023
| @@ -48,66 +49,6 @@ const ( | |||
| queryStringParamTotalShards = "totalshards" | |||
| ) | |||
|
|
|||
| // parseRange parses a Range header string as per RFC 7233. Only the first range | |||
| // is returned. If no range is specified, parseRange returns 0, size. | |||
| func parseRange(s string, size int64) (offset, length int64, _ error) { | |||
There was a problem hiding this comment.
replaced with standard library call
peterjan
approved these changes
Apr 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.