Add automated test to reproduce download corruption #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/reproduction-test-corruption
branch
from
e4af7e5
to
c202f99
Compare
Merged
peterjan
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
PR looks great, most of my comments are good to resolve if you disagree.
I think in your DRAFT there was a change to TestUploadDownload or whatever where we upload a small and large file, the large file wasn't large enough. That change seems to be gone and I think we should re-add that either here or in your other PR.
worker/transfer.go
Outdated
| @@ -421,11 +465,11 @@ func parallelDownloadSlab(ctx context.Context, sp storeProvider, ss object.SlabS | |||
| return shards, timings, nil | |||
| } | |||
|
|
|||
| func downloadSlab(ctx context.Context, sp storeProvider, out io.Writer, ss object.SlabSlice, contracts []api.ContractMetadata, downloadSectorTimeout time.Duration, logger *zap.SugaredLogger) ([]int64, error) { | |||
| func downloadSlab(ctx context.Context, sp storeProvider, out io.Writer, ss object.SlabSlice, hosts []api.ContractMetadata, downloadSectorTimeout time.Duration, logger *zap.SugaredLogger) ([]int64, error) { | |||
There was a problem hiding this comment.
should we add similar unique-checks in uploadSlab, I was expecting changes to both the download and upload code
There was a problem hiding this comment.
I didn't want to force that restriction upon the user yet. So if you created a contract set a certain way you can still use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reproduction test concerning the issue debugged in #298.
It also contains the fix for the issue which was the download code being unable to handle slabs where multiple shards were accidentally uploaded to the same host.