Lower the ipv6FilterRange from 58 to 32 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticing that lots of ISPs hand out full /64 prefixes to customers I did some research to see the size of prefixes that ISPs themselves have available.
Here are two examples for Google and Hetzner:
https://radar.qrator.net/as24940/ipv6-prefixes
https://radar.qrator.net/as15169/ipv6-prefixes
Considering that we used 54 bits and some providers have /32 or even lower prefixes to hand IPs out from, that leaves us with potentially millions of hosts on the same ISP.
So this PR lowers that number to 32 to only allow for 1 host per /32 range.