Scanner Config #677
Merged
Scanner Config #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
approved these changes
Oct 31, 2023
|
added |
…o pj/scanner-config
…o pj/scanner-config
…o pj/scanner-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should move
MinRecentScanFailuresfrom scanner toHostsConfig. It works together withMaxDowntimeHoursand we even pass it into thebuswhen removing offline hosts in the autopilot so should be moved now before v1.NOTE: I considered renaming/hosts/removeto/hosts/prunemaking it more consistent with how we refer to it and how we name things but in the end didn't do it. Decided to leave it here, if you think we should go ahead and do that too I'll add it to this PR cc @ChrisSchinnerl .