Migration Critical Downloads #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/low-health
branch
from
7a48f26
to
cb16ec1
Compare
…o pj/low-health
…o pj/low-health
|
pushing it into review, thinking of adding a test for this but it's obviously a little tricky to write a solid integration test for this |
peterjan
force-pushed
the
pj/low-health
branch
from
fadc903
to
6b75878
Compare
peterjan
commented
Nov 10, 2023
| @@ -140,6 +140,10 @@ func (sb HostScoreBreakdown) String() string { | |||
| return fmt.Sprintf("Age: %v, Col: %v, Int: %v, SR: %v, UT: %v, V: %v, Pr: %v", sb.Age, sb.Collateral, sb.Interactions, sb.StorageRemaining, sb.Uptime, sb.Version, sb.Prices) | |||
| } | |||
|
|
|||
| func (hgb HostGougingBreakdown) DownloadGouging() bool { | |||
There was a problem hiding this comment.
leaving comment to prevent merge - should extend UI to make sure we can set the surcharge multiplier
…o pj/low-health
|
@ChrisSchinnerl ready for another 👀 |
ChrisSchinnerl
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the behaviour of
renterdwhen it comes to the migration of critically low-health slabs in an attempt to avoid file loss at all costs. We found that from time to time we fail to migrate (low-health) slabs due to some hosts that are price gouging.This PR introduces an extra gouging setting (
MigrationSurchargeMultiplier) that essentially says "when it's really necessary, I allow overpaying by a factor of x for some critical sector downloads that would otherwise be the cause of migration failure and potential file loss".I added two alerts that bubble up when necessary to notify the user his gouging settings are either working, or need to be adjusted. I had to refactor the download code a bit, I tried to keep the refactoring to a minimum and would like to keep it more or less like this to avoid needlessly falling into a huge download refactor rabbit-hole right before 1.0