Pruning Low Payout #734
Merged
Pruning Low Payout #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| proofSize = minMessageSize | ||
| // calculate the cost | ||
| var remainingDuration uint64 // not needed for deletions | ||
| rpcCost, err := settings.RPCWriteCost(actions, numSectors, remainingDuration, true) |
There was a problem hiding this comment.
Is it not enough to switch to RPCWriteCost. Isn't this the same math said uses for computing the cost?
There was a problem hiding this comment.
Unfortunately it's not 1-1. For example siad has a min len check that's not in coreproofSize < modules.RPCMinLen. On our integrity node I logged got vs want cost and found the diff was one sector in dl bandwidth pricing...
There was a problem hiding this comment.
After getting rid of siad hosts we can obviously switch to RPCWriteCost
…o pj/pruning-low-payout
ChrisSchinnerl
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some pruning errors on the integrity node. This PR essentially overpays on pruning related RPCs for hosts below
1.6.0. After deploying the errors went away.