Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Overdrive #797

Merged
merged 26 commits into from
Dec 12, 2023
Merged

Upload Overdrive #797

merged 26 commits into from
Dec 12, 2023

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Dec 6, 2023

I discovered our cancelled out overdrives essentially make an uploader unusable for all other sectors. I refactored in a couple of steps and the more I changed the more it made sense to essentially extend sectorCtx with not just its ctx and cancel func but everything related to the sector.

@peterjan peterjan self-assigned this Dec 6, 2023
worker/upload.go Outdated Show resolved Hide resolved
worker/memory.go Outdated Show resolved Hide resolved
worker/upload_params.go Outdated Show resolved Hide resolved
worker/upload.go Outdated Show resolved Hide resolved
worker/upload.go Outdated Show resolved Hide resolved
worker/upload.go Outdated Show resolved Hide resolved
worker/upload.go Outdated Show resolved Hide resolved
worker/upload.go Outdated Show resolved Hide resolved
@ChrisSchinnerl
Copy link
Member

 === RUN   TestUploadDownloadSpending
  2023-12-07T16:47:47Z	ERROR	autopilot.migrator	autopilot/migrator.go:158	worker: migration 1/3 failed, key: key:baf2a3a18250a0b825bec2c8d2f7218208333f8005d88b7d2d119ae39b1c9dd7, health: 0, overpaid: false, err: failed to migrate slab; failed to upload slab for migration: 0 < 1: not enough contracts to support requested redundancy
  2023-12-07T16:47:47Z	ERROR	worker.worker	worker/worker.go:1137	couldn't upload object: no candidate uploader found
      cluster_test.go:879: couldn't upload object: no candidate uploader found

Seems like tests are failing due to this

tracing/tracing.go Show resolved Hide resolved
worker/upload.go Outdated Show resolved Hide resolved
worker/upload.go Outdated Show resolved Hide resolved
@ChrisSchinnerl
Copy link
Member

Lgtm but this one test keeps failing for some reason

@peterjan peterjan force-pushed the pj/uploads branch 2 times, most recently from 846c9d8 to c7d5123 Compare December 11, 2023 15:51
@ChrisSchinnerl ChrisSchinnerl merged commit 599ae43 into master Dec 12, 2023
6 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the pj/uploads branch December 12, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants