Pruning Gouging Checks #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding test |
ChrisSchinnerl
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
@alexfreska can you double check that this doesn't break the UI? The gouging overview for a host changed to no longer have the v2 and v3 fields in the response.
|
This will most definitely break the UI, we could tag 0.7.0 without it? |
ui: v0.36.0
…o pj/pruning-gouging-checks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add gouging checks to the pruning code. I figured it'd be two lines but then realised we removed as much RHPv2 gouging checks as we possible could. Instead of re-adding them I'm re-using the RHPv3 download checks to cover pruning since pruning is essentially mostly base cost and download bandwidth anyway, very similar to downloads.