Allow adding metadata to objects #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
peterjan
force-pushed
the
pj/metadata
branch
from
3f04054
to
908e727
Compare
peterjan
force-pushed
the
pj/metadata
branch
from
36d72ab
to
420f4db
Compare
|
still need to convert migrations to raw sql migrations |
|
verified updated code on my node and rclone sync still shows |
ChrisSchinnerl
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds user metadata to objects. Some S3 clients send metadata in the form of
X-Amz-Meta-headers and then rely on the API to return them when makingHEADand/orGETrequests. We had an issue report of a user that was experiencing continuous syncing of the same files.I originally extended the
ObjectMetadatawith this user defined metadata, but eventually found that was not necessary and that cleaned things up a bunch. Multipart uploads are somewhat annoying, we have to add a separate table just for those and it's attached onCreateMultipartUpload.I would not include it in 1.0.0 simply because it touches quite a lot of things. I am running it without issues on my personal node now though.
Fixes #833