Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same buffer being in 'completedBuffers' multiple times #854

Merged
merged 4 commits into from Jan 8, 2024

Conversation

ChrisSchinnerl
Copy link
Member

This caused buffers to be closed multiple times which led to rare error messages in the logs

@ChrisSchinnerl ChrisSchinnerl self-assigned this Dec 21, 2023
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review December 21, 2023 17:05
peterjan
peterjan previously approved these changes Dec 22, 2023
@ChrisSchinnerl ChrisSchinnerl marked this pull request as draft December 22, 2023 08:25
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review December 22, 2023 09:35
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one minor suggestion

stores/slabbuffer.go Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl merged commit 4a0b8ac into dev Jan 8, 2024
6 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/mark-buffer-complete-fix branch January 8, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

2 participants