improve shutdown of host interaction recorders #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
force-pushed
the
pj/improve-recorder-shutdown
branch
from
bea473b
to
23b1ace
Compare
|
I resolved all comments. I do see the (edge-case) race but as this is an improvement over what we have and since we have to revisit recorders after RHPv4 I propose we merge and revisit it later. Graceful shutdowns do feel nice and with current implementation we do record all host interactions, in the event of an edge case we only log an error for an interaction we later successfully record in the bus. Providing the uploads/downloads finish in due time. |
ChrisSchinnerl
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly improves how we handle host interactions on worker shutdown by swapping out the flush context with the context we pass to the worker on shutdown, essentially allowing interactions to be flushed for as long as we allow the worker to shut down gracefully. On shutdown we also set the interval to 0 essentially immediately flushing the interactions to the bus. Both these changes ensure that all interactions that occur during a worker shutdown have every chance of making it into the database.