Make SQLStore implement SingleAddressStore #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pj/single-address-store
|
@ChrisSchinnerl this test won't pass for a short while until we move over the consensus subscription code fully |
… pj/single-address-store
ChrisSchinnerl
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the
SQLStoreimplement theSingleAddressStore. This will allow us to get rid of theSingleAddressWalletin favour of the one incoreutilsin a next step.There's a couple of small quirks here but all in all I think it's fine, the
SiacoinElementandTransactiontype differ very slightly from the ones incoreutilsbut I wrote a little convert method for each to ensure the output of thebusAPI remains the same. I don't think this is absolutely necessary since we'll have to break it at some point, but it's nice that we don't have to for the time being.Another one is the
beforeandsincehack where we fetch all transactions if either of those is given and paginate manually. The UI doesn't use these parameters so again I don't think it's that big of a deal. I guess we should mark them as deprecated in postman. I'll do that.