Extend contract set change alerts with host info #966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds host info to the contract set change alert, as requested in #963
REQUIRES UI CHANGE
This PR requires an accompanying UI change to ensure the alert is displayed properly. I'm wondering whether we should create a list of alerts + properties in the frontend, and only display those keys and alerts. That way we could always maintain backwards compatibility in the backend, but tweak or add alerts. We can merge that separately from the frontend and then when the frontend made the required changes we can get rid of the redundant/old compat code we had to add. Downside would be that every new alert or added property would need a UI update to get displayed.
Example screenshot:
Example JSON: